Fix source_prefix default value#26654
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Oct 10, 2023
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request updates the
run_summarization.pyscript in the PyTorch implementation to fix the default value ofsource_prefix. Currently, the default value is set to"", which can be misleading when fine-tuning T5 models. This PR sets the default value toNone, aligning it with other implementations and ensuring that users are prompted with a warning when not providing a source prefix.Fixes #26653
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?