Skip to content

Fix source_prefix default value in run_summarization.py #26653

@jheitmann

Description

@jheitmann

System Info

  • transformers version: 4.35.0.dev0
  • Platform: macOS-13.4-arm64-arm-64bit
  • Python version: 3.10.10
  • Huggingface_hub version: 0.17.3
  • Safetensors version: 0.4.0
  • Accelerate version: 0.23.0
  • Accelerate config: not found
  • PyTorch version (GPU?): 2.1.0 (False)
  • Tensorflow version (GPU?): not installed (NA)
  • Flax version (CPU?/GPU?/TPU?): not installed (NA)
  • Jax version: not installed
  • JaxLib version: not installed
  • Using GPU in script?: no
  • Using distributed or parallel set-up in script?: no

Who can help?

@ArthurZucker @younes

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

Run the following command to reproduce the behavior:

python examples/pytorch/summarization/run_summarization.py \
    --model_name_or_path t5-small \
    --do_train \
    --do_eval \
    --dataset_name cnn_dailymail \
    --dataset_config "3.0.0" \
    --output_dir /tmp/tst-summarization \
    --per_device_train_batch_size=4 \
    --per_device_eval_batch_size=4 \
    --overwrite_output_dir \
    --predict_with_generate

Expected behavior

When a user fine-tunes a T5 model without explicitly setting the source_prefix, the warning message prompting users to set a source_prefix is not displayed. This is because the source_prefix is set to its default value of "" in this PyTorch implementation of the run_summarization.py script, which is not equivalent to None. This behavior is inconsistent with other implementations, where the default value of source_prefix is None, and the warning is displayed when not provided by the user.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions