[CodeLlamaTokenizerFast] Fix fix set_infilling_processor to properly reset#26041
Merged
ArthurZucker merged 5 commits intohuggingface:mainfrom Sep 8, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
reviewed
Sep 8, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
I'm sure it fixes the issue - I can't approve yet though as I've no idea about the intended behaviour of this method!
| ] | ||
| ) | ||
| self.update_post_processor() | ||
| return |
Contributor
There was a problem hiding this comment.
This method would really benefit from a docstring - it's not clear to me what's supposed to be happening and what reset is supposed to do
amyeroberts
reviewed
Sep 8, 2023
src/transformers/models/code_llama/tokenization_code_llama_fast.py
Outdated
Show resolved
Hide resolved
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…rly reset (huggingface#26041) * fix `set_infilling_processor` to properly reset * Add docstring! * fixups * more details in the docuemtation about the tokenization * styl;e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #26038 were the
set_infilling_processorwas not properly reseting the template processing forCodeLlama