save space when converting hf model to megatron model.#25950
Merged
LysandreJik merged 4 commits intohuggingface:mainfrom Sep 5, 2023
Merged
save space when converting hf model to megatron model.#25950LysandreJik merged 4 commits intohuggingface:mainfrom
LysandreJik merged 4 commits intohuggingface:mainfrom
Conversation
ArthurZucker
approved these changes
Sep 4, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Looks good to me 😉
I think there are other places in the code that might also need this (final layer norm?)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Contributor
Author
|
you are right, I add the LM head. But I think layer norm doesn't need this method， they are replicated across the tensor paralledl group. |
Collaborator
|
Thanks! Looks good to me 😉 |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…5950) * fix convert megatron model too large * fix convert megatron model too large
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #25911
when save megatron models, clone the tensor to avoid saving the original tensor.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Yes
Who can review?
@ArthurZucker
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.