[ASR Pipe Test] Fix CTC timestamps error message#25727
Merged
sanchit-gandhi merged 1 commit intohuggingface:mainfrom Aug 24, 2023
Merged
[ASR Pipe Test] Fix CTC timestamps error message#25727sanchit-gandhi merged 1 commit intohuggingface:mainfrom
sanchit-gandhi merged 1 commit intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test
test_chunking_and_timestampsfailed on the nightly run when checking that the argumentreturn_timestamps=Truegave the correct error message for CTC models. This is because the string pattern(char)in the error message was closing the regex expression. Removing it allows the test to pass as expected.