Fix failing test_batch_generation for bloom#25718
Merged
Conversation
ydshieh
commented
Aug 24, 2023
|
|
||
| input_sentence = ["I enjoy walking with my cute dog", "I enjoy walking with my cute dog"] | ||
|
|
||
| input_ids = tokenizer.batch_encode_plus(input_sentence, return_tensors="pt", padding=True) |
ydshieh
commented
Aug 24, 2023
| input_sentence = ["I enjoy walking with my cute dog", "I enjoy walking with my cute dog"] | ||
|
|
||
| input_ids = tokenizer.batch_encode_plus(input_sentence, return_tensors="pt", padding=True) | ||
| input_ids = input_ids["input_ids"].to(torch_device) |
ydshieh
commented
Aug 24, 2023
|
|
||
| input_ids = tokenizer.batch_encode_plus(input_sentence, return_tensors="pt", padding=True) | ||
| input_ids = input_ids["input_ids"].to(torch_device) | ||
| attention_mask = input_ids["attention_mask"] |
Collaborator
Author
There was a problem hiding this comment.
no attention_mask in the actual ids
ydshieh
commented
Aug 24, 2023
| input_ids = tokenizer.batch_encode_plus(input_sentence, return_tensors="pt", padding=True) | ||
| input_ids = input_ids["input_ids"].to(torch_device) | ||
| attention_mask = input_ids["attention_mask"] | ||
| inputs = tokenizer.batch_encode_plus(input_sentence, return_tensors="pt", padding=True) |
Collaborator
Author
There was a problem hiding this comment.
good name and avoid failure.
Collaborator
Author
I was caught by the failed CI 😢 |
|
The documentation is not available anymore as the PR was closed or merged. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#25571 changed this test. There was a tiny issue. See my comment along the change in this PR.
We should probably to change this variable names in multiple places for house keeping.
Also cc @gante 😄