Generate: add missing logits processors docs#25653
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
I've confirmed that the previously missing docs are now properly rendered in the doc preview 👍 |
ArthurZucker
left a comment
There was a problem hiding this comment.
Would be cool if the different logits appear in the small summary to directly jump to one or another:
given that there are so many different ones WDYT?
Also I noticed that the logit_process.py is not doctested, might be because some of the examples use big models, but would be cool to support them.
|
@ArthurZucker re tests -- fully on board. If you're okay with it, I'd like to do it on a separate PR :) Ditto for the side bar on the left, it is in need of an update! |
0c7ac54 to
5406873
Compare
5406873 to
e7c75a0
Compare
|
@ArthurZucker ready for a re-review! To recap, the previously reviewed version:
This version also:
In parallel, other concerns raised in the PR are being tackled in another places:
|
|
(preview of the left-handed side TOC) |
ArthurZucker
left a comment
There was a problem hiding this comment.
Great work 🤗 looks a lot better
What does this PR do?
Some logits processor classes were missing on the docs. This PR corrects it by:
1 - Adding all missing logits processors to the docs
2 - Adding missing top-level imports (to stay consistent with previously existing logits processors)