fix get_keys_to_not_convert function#24095
Merged
SunMarc merged 2 commits intohuggingface:mainfrom Jun 8, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Jun 7, 2023
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Will defer to @younesbelkada here. Note that the first changes make tied_keys contain the name of all tied parameters (whereas it was ignoring the first key for each group of tied parametrs before), not sure if this is intended or not.
younesbelkada
approved these changes
Jun 8, 2023
Contributor
younesbelkada
left a comment
There was a problem hiding this comment.
Awesome work! Thanks a lot for fixing
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix get_keys_to_not_convert funct * Fix style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix the behavior of the get_keys_to_not_convert function for the following cases:
named_children()instead[['lm_head.weight', 'model.decoder.embed_tokens.weight']] -> ['model.decoder.embed_tokens.weight'])