Fix confusing transformers installation in CI#23465
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Merged
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As mentioned in this comment, the
transformersin CI runs is not the same one installed during docker image build.Furthermore, for past CI, we didn't update the docker image daily (there is no need to update the fixed 3rd-packages environment), but the
transformerscode is the latest one being test against. We getas the
transformersis the one during docker image build (months ago) which has noHfDoctestModuleat the time.To avoid and fix all such super confusing failures in the future, it's better to install the
transformersagain in the edit mode in the workflow files.I don't change the daily CI workflow file yet in this PR - I would wait this PR showing the change actually fix issues.