[SAM] fix sam slow test#23376
Conversation
|
Fix for the notebook: huggingface/notebooks#371 |
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for fixing! Good to see type of boxes and points now consistent.
Before merging, so that I understand the consequences - how did the slow tests run before? As I understand it, the tests are now failing because of the assertions being raised based on input type checks. However, the previous inputs were still being successfully processed i.e. the test would run without issue and produce the same results. If this is the case - do we need the logic checks from #23295?
As an additional side note, I just noticed the exception messages should be updated - you can't have floating integers :)
|
Indeed the tests were passing before because the processor was force unsqueezeing the boxes here:
Hahah yes, thanks for noticing! Copilot does some bad job sometimes ... will update that as well |
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for fixing and taking the time to explain about previously passing tests!
|
Thanks a lot @amyeroberts ! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
* fix sam slow test * oops * fix error message
* fix sam slow test * oops * fix error message
What does this PR do?
This PR fixes the slow tests that were failing due to #23295
In fact, in the slow test that we have designed, we forgot to use the correct format for the input bounding boxes
Will address a PR on
notebooksto address the changes in the example notebookcc @ydshieh @amyeroberts