[Blip] Remove redundant shift right#23153
Merged
younesbelkada merged 4 commits intohuggingface:mainfrom May 19, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Closed
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* remove redundant shit right * fix failing tests * this time fix tests
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* remove redundant shit right * fix failing tests * this time fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #23000
In fact
_shift_rightdoes not need to be called insideBlipForQuestionAnsweringas the right shifting of the tokens is done directly on the text decoder as mentioned by the user. Therefore, that class will be trained to perform next-next token prediction instead of next-token prediction.The fix is to simply remove that shift method and the call to it.
cc @sgugger