Skip to content

fix _no_split_modules for Whisper model#22486

Merged
sgugger merged 1 commit intomainfrom
smangrul/update-whisper-no-split-modules
Apr 4, 2023
Merged

fix _no_split_modules for Whisper model#22486
sgugger merged 1 commit intomainfrom
smangrul/update-whisper-no-split-modules

Conversation

@pacman100
Copy link
Contributor

What does this PR do?

  1. fix _no_split_modules for Whisper model

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this!
Can you confirm accelerate tests pass ?

RUN_SLOW=1 pytest -m accelerate_tests tests/models/whisper/test_modeling_whisper.py

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 31, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

Copy link
Contributor

@sanchit-gandhi sanchit-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pacman100!

@sanchit-gandhi sanchit-gandhi requested a review from sgugger April 4, 2023 17:00
@sgugger sgugger merged commit 48fbd8f into main Apr 4, 2023
@sgugger sgugger deleted the smangrul/update-whisper-no-split-modules branch April 4, 2023 17:01
raghavanone pushed a commit to raghavanone/transformers that referenced this pull request Apr 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants