Add clean_up_tokenization_spaces to config#22341
Merged
ArthurZucker merged 12 commits intohuggingface:mainfrom Mar 29, 2023
Merged
Add clean_up_tokenization_spaces to config#22341ArthurZucker merged 12 commits intohuggingface:mainfrom
ArthurZucker merged 12 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
Author
|
cc @Narsil |
5 tasks
Collaborator
Author
|
Also linked to #20846. A follow up PR can now be made to add a simple warning if the default value is set to |
Collaborator
Author
|
It seems like no model defaulted to use |
Narsil
reviewed
Mar 27, 2023
sgugger
approved these changes
Mar 27, 2023
Narsil
reviewed
Mar 28, 2023
Contributor
Narsil
left a comment
There was a problem hiding this comment.
Very nice readable test !
Merged
Co-authored-by: Nicolas Patry <patry.nicolas@gmail.com>
…to fix-cleanup-tokenization
raghavanone
pushed a commit
to raghavanone/transformers
that referenced
this pull request
Apr 5, 2023
* add draft changes * fix failing wav2vec * style * make sure that the argument is saved + add tests * style * fixup * update test * default clean_up_tokenization_spaces to False for Bloom and Llama * Update code based on review Co-authored-by: Nicolas Patry <patry.nicolas@gmail.com> * style * quality --------- Co-authored-by: Nicolas Patry <patry.nicolas@gmail.com>
xloem
pushed a commit
to xloem/transformers
that referenced
this pull request
Apr 10, 2023
* add draft changes * fix failing wav2vec * style * make sure that the argument is saved + add tests * style * fixup * update test * default clean_up_tokenization_spaces to False for Bloom and Llama * Update code based on review Co-authored-by: Nicolas Patry <patry.nicolas@gmail.com> * style * quality --------- Co-authored-by: Nicolas Patry <patry.nicolas@gmail.com>
4 tasks
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* add draft changes * fix failing wav2vec * style * make sure that the argument is saved + add tests * style * fixup * update test * default clean_up_tokenization_spaces to False for Bloom and Llama * Update code based on review Co-authored-by: Nicolas Patry <patry.nicolas@gmail.com> * style * quality --------- Co-authored-by: Nicolas Patry <patry.nicolas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DRAFT