Skip to content

Support turning off the model uploading in ClearML#20969

Merged
sgugger merged 4 commits intohuggingface:mainfrom
david1542:support-log-model-flag-clearml
Jan 6, 2023
Merged

Support turning off the model uploading in ClearML#20969
sgugger merged 4 commits intohuggingface:mainfrom
david1542:support-log-model-flag-clearml

Conversation

@david1542
Copy link
Contributor

@david1542 david1542 commented Jan 2, 2023

What does this PR do?

Support turning off the model uploading in ClearML using an environment variable called CLEARML_LOG_MODEL

Fixes #20889

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@david1542 david1542 mentioned this pull request Jan 2, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 2, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger reviewed Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Could you just make sure to document this new env variable in the docstring of the callback (along the other ones)?

@dudulasry
Copy link
Contributor

dudulasry commented Jan 3, 2023

Hi @sgugger :) I modified the docstring, as you suggested. Can you please have a look? 🙏

@sgugger
Copy link
Collaborator

sgugger commented Jan 4, 2023

Code looks good but it seems there is an issue with your CircleCI permissions, the tests won't run.
Could you try refreshing your permissions as shown here?

@david1542
Merge branch 'main' into support-log-model-flag-clearml
c9125f5 
# Conflicts:
#	src/transformers/integrations.py
@david1542
Copy link
Contributor Author

david1542 commented Jan 5, 2023

@sgugger I re-authenticated to CircleCI, and it seems that the CI passed :)
Can you have a look and approve? :)

sgugger
sgugger approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Just one last comment and we should be good to merge.

@david1542 @sgugger
Adjust new doc addition to the new style
776fa24 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@david1542
Copy link
Contributor Author

david1542 commented Jan 6, 2023

@sgugger Thanks for the feedback. I accepted your change :)

@sgugger sgugger merged commit 61e068e into huggingface:main Jan 6, 2023
@sgugger
Copy link
Collaborator

sgugger commented Jan 6, 2023

Thanks for your contribution!

silverriver pushed a commit to silverriver/transformers that referenced this pull request Jan 6, 2023
@david1542 @dudulasry
@sgugger @silverriver
Support turning off the model uploading in ClearML (huggingface#20969)
28a661d 
* Add support for turning off the model uploading in ClearML

* Add documentation for the CLEARML_LOG_MODEL environment variable

* Adjust new doc addition to the new style

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

Co-authored-by: Dudu Lasry <dudu.lasry@viz.ai>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable ClearML automatic model uploading

4 participants

@david1542 @HuggingFaceDocBuilderDev @dudulasry @sgugger