Fix expected values for TF-ESM tests#20680
Merged
Rocketknight1 merged 1 commit intomainfrom Dec 8, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
approved these changes
Dec 8, 2022
Collaborator
ydshieh
left a comment
There was a problem hiding this comment.
confirmed pass on T4 runners!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I computed the expected values for these tests on my local machine with TF32 enabled - my bad! This replaces them with the correct float32 expected outputs.