Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
Author
|
Merging to have tests passing on main, but I will address any comment in followup PRs :-) |
ydshieh
reviewed
Dec 6, 2022
| with self.assertRaisesRegex( | ||
| EnvironmentError, | ||
| "hf-internal-testing/config-no-model does not appear to have a file named tf_model.h5", | ||
| "hf-internal-testing/config-no-model does not appear to have a file named pytorch_model.bin", |
Collaborator
There was a problem hiding this comment.
Good to see this fixed the CI, however this is somehow confusing: it is TFAutoModel, but seeing the expected error being just pytorch_model.bin here blows my mind.
(I know the full error is hf-internal-testing/config-no-model does not appear to have a file named pytorch_model.bin, tf_model.h5 or model.ckpt)
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test for file not found in the TensorFlow auto model tests is failing on main as the message does not match exactly (see here). This PR fixes that.