[Whisper] Fix decoder ids methods#20599
Merged
sanchit-gandhi merged 2 commits intohuggingface:mainfrom Dec 5, 2022
Merged
Conversation
5 tasks
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Dec 5, 2022
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for the quick fix
Comment on lines
+586
to
+588
| self.set_prefix_tokens(task=task, language=language, predict_timestamps=not no_timestamps) | ||
| forced_decoder_ids = [(rank + 1, token) for rank, token in enumerate(self.prefix_tokens)] | ||
| return forced_decoder_ids |
Collaborator
There was a problem hiding this comment.
Nice catch! I should have realized when reviewing!
| msg="`processor` and `feature_extractor` model input names do not match", | ||
| ) | ||
|
|
||
| def test_get_decoder_prompt_ids(self): |
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* [Whisper] Fix decoder ids methods * enum property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous PR #20589 incorrectly returned a list of forced decoder ids:
Print Output:
The correct format is a nested list of decoder ids, where the first element of each list specifies the position of the forced token and the second the token id:
Print Output:
(at position 1 we force token 50257, at 2 we force 50358, at 3 we force 50362)
The PR also implements a test, thus making sure that no such error can be made again 😅
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.