Vision processors - replace FE with IPs#20590
Merged
amyeroberts merged 10 commits intohuggingface:mainfrom Dec 9, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
d9d2f37 to
11542e6
Compare
sgugger
reviewed
Dec 5, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks! Just one comment on the deprecation warning to propagate to all processors.
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
021313a to
c0f2c53
Compare
ydshieh
reviewed
Dec 7, 2022
| "`feature_extractor_class` is deprecated and will be removed in v5. Use `image_processor_class` instead.", | ||
| FutureWarning, | ||
| ) | ||
| return self.image_processor_class |
Collaborator
There was a problem hiding this comment.
Should we also allow to give feature_extractor ?
Collaborator
There was a problem hiding this comment.
I mean adding a property feature_extractor too ?
Contributor
Author
There was a problem hiding this comment.
Yes, that's a good point. I'll add that too.
Contributor
Author
There was a problem hiding this comment.
I've added a feature_extractor property to all the processors. Let me know if that matches what you were thinking :)
sgugger
approved these changes
Dec 7, 2022
155b2bd to
ba853bc
Compare
5 tasks
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* Replace FE references with IPs * Update processor tests * Update src/transformers/models/clip/processing_clip.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Update src/transformers/models/clip/processing_clip.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Update warning messages v4.27 -> v5 * Fixup * Update Chinese CLIP processor * Add feature_extractor property * Add attributes * Add tests Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces feature extractors with image processors in the
Processorclass which bundle together tokenizers and feature extractor.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.