Skip to content

Fix flax GPT-J-6B linking model in tests#20556

Merged
ydshieh merged 1 commit intohuggingface:mainfrom
JuanFKurucz:fix_flax_gptj_model_link
Dec 5, 2022
Merged

Fix flax GPT-J-6B linking model in tests#20556
ydshieh merged 1 commit intohuggingface:mainfrom
JuanFKurucz:fix_flax_gptj_model_link

Conversation

@JuanFKurucz
Copy link
Contributor

What does this PR do?

Fixes the loading of the model EleutherAI/gpt-j-6B as the current code links EleutherAI/gptj-6B which does not exist and ends up failing the test.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! cc @ydshieh
Indeed the link https://huggingface.co/EleutherAI/gpt-j-6B works but https://huggingface.co/EleutherAI/gptj-6B is broken

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JuanFKurucz .

(These 2 tests are not run in our CI though)

@ydshieh ydshieh merged commit e135a6c into huggingface:main Dec 5, 2022
@JuanFKurucz JuanFKurucz deleted the fix_flax_gptj_model_link branch December 5, 2022 14:45
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants