Add entries to FEATURE_EXTRACTOR_MAPPING_NAMES#20551
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Dec 5, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
They should definitely be there, thanks for fixing!
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add entries to
FEATURE_EXTRACTOR_MAPPING_NAMESNot sure if there was any reason not to add these entries in
FEATURE_EXTRACTOR_MAPPING_NAMES.Furthermore, without these entries, we get some test failures for the (WIP) improved pipeline tests, because we now can generate tiny models for these config classes with the corresponding tokenizer/processor. (Previously these couldn't be generated).
The failures are because this line
transformers/tests/pipelines/test_pipelines_feature_extraction.py
Line 182 in cc3d0e1
is not able to skip relevant tests for these configs/models.
Remark: I am going to add them to
TOKENIZER_MAPPING_NAMEStoo