Skip to content

[CI, WHISPER] fix the latest failing test #20493

Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom
ArthurZucker:ci-whisper
Nov 30, 2022
Merged

[CI, WHISPER] fix the latest failing test #20493
ArthurZucker merged 1 commit intohuggingface:mainfrom
ArthurZucker:ci-whisper

Conversation

@ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Nov 29, 2022

What does this PR do?

In a recent update, we followed the original code which changed some of the suppress tokens for better performances. This lead to a small change in the output of on particular case. Tested with the original code and we have the correct output now!

See here for the particular commit

@ArthurZucker ArthurZucker changed the title Expected output for the test changed [CI, WHISPER] fix the latest failing test Nov 29, 2022
@ArthurZucker ArthurZucker requested a review from ydshieh November 29, 2022 18:03
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArthurZucker!

BTW, let's be more explicit in the PR description: a link to the Hub PR or Hub commit maybe?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@ArthurZucker ArthurZucker merged commit 761b3fa into huggingface:main Nov 30, 2022
@ArthurZucker ArthurZucker deleted the ci-whisper branch November 30, 2022 14:07
@ArthurZucker ArthurZucker mentioned this pull request Dec 5, 2022
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants