Fix result saving errors of pytorch examples#20276
Merged
sgugger merged 1 commit intohuggingface:mainfrom Nov 16, 2022
Merged
Conversation
sgugger
approved these changes
Nov 16, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20079. This PR fixed potential
KeyErrors on saving results in most PyTorch examples, by prefixing metric keys instead of directly accessing metrics by key.In addition, this PR replaced the argument
--max_lengthwith--max_seq_lengthinrun_swag_no_trainer.py, to make the no-trainer version consistent with the trainer version and the README instructions.Before submitting
Pull Request section?
to it if that's the case. Exception on saving results in official glue example scripts #20079
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sgugger
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.