type hints for pytorch models#17064
Merged
Rocketknight1 merged 4 commits intohuggingface:mainfrom May 5, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Rocketknight1
approved these changes
May 4, 2022
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Overall, this looks great! I made a few comments, but some of them are just questions. The main one was the introduction of the extra argument - are you sure that's correct?
Contributor
Author
|
@Rocketknight1 I have added the changes suggested by you & all checks are passing! |
Member
|
Looks great, thanks for the PR! |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* type hints for pytorch models * fixed import error * fixed some errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16059 :
Added type hints for pytorch models -
canine,convbert,convnext,encoder_decoder,gpt2,gptj,megatron_bert,mobilebert,perceiver,retribert,swin,transfo_xl&van.For the code quality, I ran
make fixupand reformatted the codes & also resolved consistency problems across other models [which were -decision_transformer,glpn,maskformer, &segformer]Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1