Update no_trainer examples to use new logger#17044
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 2, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Very nice! You can propagate this change on the other example scripts!
Contributor
Author
|
rereview for propagate sanity check then all good 🤗 |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
May 3, 2022
* Propagate and fix imports
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Propagate and fix imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
no_trainerexamples to use the new Accelerate loggerWhat does this add?
main_process_only=Falseshould be passed in.This helps also solve an annoyance users were pointing out about repeat logs leading to misunderstandings of how the internal API was acting on
What parts of the API does this impact?
User-facing:
The examples now show using the new
get_logger()function from Accelerate