[Flax(Speech)EncoderDecoder] Fix bug in decoder_module#17036
Merged
sanchit-gandhi merged 2 commits intohuggingface:mainfrom May 2, 2022
Merged
[Flax(Speech)EncoderDecoder] Fix bug in decoder_module#17036sanchit-gandhi merged 2 commits intohuggingface:mainfrom
decoder_module#17036sanchit-gandhi merged 2 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
May 3, 2022
…#17036) * [FlaxSpeechEncoderDecoder] Fix bug in `decoder_module` * [FlaxEncoderDecoder] Fix bug in `decoder_module`
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…#17036) * [FlaxSpeechEncoderDecoder] Fix bug in `decoder_module` * [FlaxEncoderDecoder] Fix bug in `decoder_module`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current use of
decoder_moduleassumes thatencoder_hidden_statesis the fourth positional argument of the decoder's call method. We see that this is indeed true of the two current Flax decoder models:FlaxGPT2LMHeadModelandFlaxBartForCausalLM. However, for other possible decoder models, such as the work-in-progressFlaxBertForCausalLM, there may be additional positional arguments (such astoken_type_idsorhead_mask) prior toencoder_hidden_states. To handle this more general case, we should not assumeencoder_hidden_statesis necessarily the fourth positional argument, and should instead pass it as a key-word argument.