[FlaxGenerate] Fix bug in decoder_start_token_id#17035
Merged
sanchit-gandhi merged 1 commit intohuggingface:mainfrom May 2, 2022
Merged
[FlaxGenerate] Fix bug in decoder_start_token_id#17035sanchit-gandhi merged 1 commit intohuggingface:mainfrom
decoder_start_token_id#17035sanchit-gandhi merged 1 commit intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
May 3, 2022
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python,
boolis a subclass ofint, andFalsehas the value0. We observe this by calling the__bool__method of0:transformers/src/transformers/generation_flax_utils.py
Lines 266 to 268 in da47c26
In the preceding lines of code, if
decoder_start_token_idhas the value0(valid):if decoder_start_token_idwill beFalsedecoder_start_token_idwill be set toself.config.decoder_start_token_idThe correct behaviour should be that if
decoder_start_token_idhas the value0, it remains set to0, and not changed toself.config.decoder_start_token_id.