Add a check on config classes docstring checkpoints#17012
Merged
ydshieh merged 6 commits intohuggingface:mainfrom Apr 30, 2022
Merged
Add a check on config classes docstring checkpoints#17012ydshieh merged 6 commits intohuggingface:mainfrom
ydshieh merged 6 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 29, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Very nice, thanks for working on this!
4c8bf9e to
183601b
Compare
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
May 3, 2022
* Add the check * add missing ckpts * add a list to ignore * call the added check script * better regex pattern Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Add the check * add missing ckpts * add a list to ignore * call the added check script * better regex pattern Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A follow-up for #16900: add a test to make sure all config classes have at least one valid checkpoint (unless explicitly specified to ignore).
By
valid, it only means the format is valid, i.e. of the form[XXX](https://huggingface.co/XXX)withXXXbeing any string.A more strict verification could be implemented by trying to load the config. But maybe it is a bit too much?
Also fix 2 more config classes without valid checkpoint.