Make create_extended_attention_mask_for_decoder static method#16893
Merged
sgugger merged 1 commit intohuggingface:mainfrom Apr 29, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
|
(just a comment) Would it be possible to provide the code sample for the issue that occurs without this PR, or a link to the issue page? |
Member
|
Looks good to me once all the tests pass. |
sgugger
approved these changes
Apr 25, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing!
cfee494 to
c2ac8cb
Compare
Contributor
Author
The project will be released and the repo will be opened soon |
Contributor
Author
@michaelbenayoun @sgugger all tests passed |
Collaborator
|
Thanks again for your contribution! |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
May 3, 2022
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?'
create_extended_attention_mask_for_decoderdoesn't accessselfand can be@staticmethod. This resolves some issues with fx tracing for pytorch pipeline parallelism project.cc @michaelbenayoun
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.