Allow passing encoder_ouputs as tuple to EncoderDecoder Models#16814
Merged
patrickvonplaten merged 3 commits intohuggingface:mainfrom Apr 18, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
approved these changes
Apr 18, 2022
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…ngface#16814) * Add passing encoder_outputs as tuple to existing test * Add check for tuple * Add check for tuple also for speech and vision Co-authored-by: jsnfly <jsnfly@gmx.de>
|
@jsnfly , thanks you for this PR... Is it possible to do this fix for a T5 model as well.. It is also a sequence to sequence models and sometime we may want to pass a tuple to the decoder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #15536
For now I have added a test of the functionality to an existing test, since I'm not sure if there should be a separate test (or a test at all) for such a minor issue. Let me know if there is a better way.
Before submitting
Pull Request section?
to it if that's the case.
Error when passing encoder_outputs as tuple to EncoderDecoder models #15536
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@patrickvonplaten