use base_version to check torch version in torch_less_than_1_11#16806
Merged
use base_version to check torch version in torch_less_than_1_11#16806
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
…to torch_less_than_1_11
sgugger
approved these changes
Apr 18, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
It also properly deals with the dev0 and the likes, so all good to me, thanks for the fix! Could you just apply the same to the line before (is_torch_less_than_1_8) so that next time someone adds a new check like this, they don't hesitate and follow the same model?
Contributor
Author
Done. |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…ingface#16806) * use base_version * make is_torch_less_than_1_8 match 1_11 Co-authored-by: Nicholas Broad <nicholas@nmbroad.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current check
version.parse(torch.__version__) < version.parse("1.11")doesn't work if the version has additional stuff after it like1.11.0a0+17540c5.New way:
version.parse(version.parse(torch.__version__).base_version) < version.parse("1.11")This change, as suggested by @whoknowsB here, fixes it.
Fixes #16587 and #14375
Who can review?
@LysandreJik
@sgugger