[from_pretrained] refactor find_mismatched_keys#16706
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 11, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot for fragmenting. Let's way for @LysandreJik and @patrickvonplaten to approve as well before merging, as it's really core functionality and I would like one more set of eyes on it.
LysandreJik
approved these changes
Apr 12, 2022
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for your work @stas00
patrickvonplaten
approved these changes
Apr 13, 2022
Contributor
patrickvonplaten
left a comment
There was a problem hiding this comment.
Thanks for the clean-up! The code snippets are identical so great to refactor it here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors 2 large identical code copies introduced by the recent sharded checkpoint PR into a helper function which is then called from 2 places. There is no change in functionality.
It's an intermediary step for this PR: #16657 which revamps
low_cpu_mem_usageand integrates it better with the sharded checkpoint code branch.I explained here why the helper function is not a closure but needs the input args explicitly: #16657 (comment)
@sgugger