Fix LayoutLMv2 tokenization docstrings#16187
Merged
NielsRogge merged 3 commits intohuggingface:mainfrom Apr 19, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
Will open a follow-up PR for |
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Member
|
@NielsRogge can you give this a look when you have a minute? |
NielsRogge
approved these changes
Apr 19, 2022
231940c to
2077904
Compare
Contributor
Author
|
Done. |
Contributor
|
Seems like you changed some files which shouldn't be changed, like |
Contributor
|
Thanks, merging! |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Fix docstrings * Fix up * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The tokenizers of
LayoutLMv2don't acceptis_split_into_wordskeyword for__call__. Thus, I created a dedicated kwargs docstring to replace the one insrc/transformers/tokenization_utils_base.pybeing used.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@NielsRogge @LysandreJik