Fix FlaxRoFormerClassificationHead activation#16168
Merged
ydshieh merged 1 commit intohuggingface:masterfrom Mar 17, 2022
Merged
Fix FlaxRoFormerClassificationHead activation#16168ydshieh merged 1 commit intohuggingface:masterfrom
ydshieh merged 1 commit intohuggingface:masterfrom
Conversation
Collaborator
Author
|
To get more familiar with the library management/maintenance, I would like hear from you regarding: does this count as a breaking change? |
patil-suraj
approved these changes
Mar 15, 2022
Contributor
patil-suraj
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Mar 15, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
I think it's a bug fix and not a breaking change. Thanks for fixing!
Collaborator
Author
|
Merge now since this is clearly a bug, as well as a tiny change |
FrancescoSaverioZuppichini
pushed a commit
that referenced
this pull request
Mar 21, 2022
* fix activation Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
FrancescoSaverioZuppichini
pushed a commit
that referenced
this pull request
Mar 24, 2022
* fix activation Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Current
FlaxRoFormerClassificationHeaduse hard-coded activationnn.tanh, but the PyTorch versionRoFormerClassificationHeaduseACT2FN[self.config.hidden_act]which is by defaultgelu(and this is the one used by the default checkpoint's config).This PR fixes this activation issue in
FlaxRoFormerClassificationHead.