Specify numpy manually in dependencies, as it's directly used/imported#3608
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR explicitly adds numpy as a direct dependency in pyproject.toml, recognizing that it's directly imported and used throughout the codebase rather than being transitively available only through other dependencies like transformers or scipy. The dependencies list has also been reordered.
Key Changes:
- Added
numpyas an explicit dependency in the dependencies list - Reordered dependencies (moved
huggingface-hubbeforetorch, movedtqdmto the end)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomaarsen
added a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
Details
Numpy was already a required dependency, but only via
transformers/scipyetc. I also reordered the dependencies somewhat.