Skip to content

FIX Don't implicitly require transformers v4.52#2976

Merged
BenjaminBossan merged 2 commits into
huggingface:mainfrom
BenjaminBossan:fix-dont-implicitly-require-transformers-v4.52
Jan 8, 2026
Merged

FIX Don't implicitly require transformers v4.52#2976
BenjaminBossan merged 2 commits into
huggingface:mainfrom
BenjaminBossan:fix-dont-implicitly-require-transformers-v4.52

Conversation

@BenjaminBossan

Copy link
Copy Markdown
Member

Resolves #2975

In #2826, we inadvertently added a dependency on transformers v4.52 to PEFT. However, this is really only needed under very specific circumstances (aLoRA + gradient checkpointing). With this PR, unless we're in these circumstances, this requirement is no longer there.

Resolves huggingface#2975

In huggingface#2826, we inadvertently added a dependency on transformers v4.52 to
PEFT. However, this is really only needed under very specific
circumstances (aLoRA + gradient checkpointing). With this PR, unless
we're in these circumstances, this requirement is no longer there.
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@githubnemo githubnemo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenjaminBossan BenjaminBossan merged commit 9bb8947 into huggingface:main Jan 8, 2026
10 checks passed
@BenjaminBossan BenjaminBossan deleted the fix-dont-implicitly-require-transformers-v4.52 branch January 8, 2026 15:19
BenjaminBossan added a commit to BenjaminBossan/peft that referenced this pull request Jan 8, 2026
Resolves huggingface#2975

In huggingface#2826, we inadvertently added a dependency on transformers v4.52 to
PEFT. However, this is really only needed under very specific
circumstances (aLoRA + gradient checkpointing). With this PR, unless
we're in these circumstances, this requirement is no longer there.
BenjaminBossan added a commit to BenjaminBossan/peft that referenced this pull request Jan 8, 2026
BenjaminBossan added a commit that referenced this pull request Jan 9, 2026
* FIX Transformers v5 fixes (#2934)

With the v5 rc being out, we should now ensure that the PEFT tests pass.
This PR contains fixes to achieve that.

1. hub_online_once was failing because
transformers.utils.hub._is_offline_mode no longer exists. Using the new
function instead if transformers v5 is detected.

2.
tests/test_encoder_decoder_models.py::TestEncoderDecoderModels::test_merge_layers[LoraConfig-config_kwargs10-peft-internal-testing/tiny-random-BartForConditionalGeneration]
failing due to TrainableTokensWrapper not being applied to all layers
owing to changes to _tied_weights_keys.

3. While working on this, I discovered a tangential bug in
TrainableTokensLayer.get_merged_weights. This method returns a
torch.Tensor but the expected type is nn.Parameter (since foo.bar.weight
is supposed to be a nn.Parameter). This type mismatch would cause
torch's model.get_parameter, which I used in
_get_module_names_tied_with_embedding, to fail. At first, I wanted to
change the return type to nn.Parameter but this causes all kinds of
issues. Therefore, I left this bug as is. Instead, in
_get_module_names_tied_with_embedding, I opted to use attrgetter instead
of model.get_parameter.

* FIX Detect if torch.distributed is available (#2963)

E.g. it's not available for the torch rocm build.

Signed-off-by: vladmandic <mandic00@live.com>

* FIX Don't implicitly require transformers v4.52 (#2976)

Resolves #2975

In #2826, we inadvertently added a dependency on transformers v4.52 to
PEFT. However, this is really only needed under very specific
circumstances (aLoRA + gradient checkpointing). With this PR, unless
we're in these circumstances, this requirement is no longer there.

* Release: v0.18.1

Contains the following changes:

- #2934
- #2963
- #2976

---------

Signed-off-by: vladmandic <mandic00@live.com>
Co-authored-by: Vladimir Mandic <mandic00@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit 30a19a0 (gradient checkpointing) requires transformers>=4.52.0

3 participants