[SvelteKit migration] to latest Sveltekit version#396
Merged
Conversation
mishig25
added a commit
to huggingface/transformers
that referenced
this pull request
Sep 7, 2023
f7d4342 to
fd328fd
Compare
fd328fd to
8dd0112
Compare
mishig25
added a commit
to huggingface/transformers
that referenced
this pull request
Sep 24, 2023
Member
|
Wow 🤯 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Migrate to latest SvelteKit
The previous SvelteKit that was used in doc-builder was an pre-1.0 release one. There has been a lot of changes on SvelteKit, including new routing mechanism. Overall, it is a good time to migrate to the latest sveltekit and keep
doc-builderup-to-dateNot sure if there will be any performance gains in building doc html files. If so, that would be nice.
todos: