👷 Add pre_command input to CI job#369
Merged
Merged
Conversation
Member
Author
|
Merging to try out in @huggingface/js |
Contributor
|
Sweet! |
Member
Author
|
messed up updating build_pr_documentation - fixed in 550d6e3 |
coyotte508
added a commit
that referenced
this pull request
Apr 29, 2023
Contributor
|
Thanks for quickly fixing the break in the PR documentation, but can we maybe wait for a review before merging something like this? It is always possible to test a branch by installing doc-builder from that branch or executing the workflow template from a branch, so the argument of "merging quickly to help xxx" is not a good one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #360
Slack: https://huggingface.slack.com/archives/C04U1CZQBQX/p1682775421137039 cc @xenova (hopefully it'll fix)