Skip to content

Add repo_owner input to build workflows#302

Merged
mishig25 merged 1 commit into
mainfrom
add-repo-owner-to-build-workflows
Sep 27, 2022
Merged

Add repo_owner input to build workflows#302
mishig25 merged 1 commit into
mainfrom
add-repo-owner-to-build-workflows

Conversation

@nateraw

@nateraw nateraw commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

Resolves #300. Any thoughts on "required: true" vs "required: false" would be nice here :).

@nateraw nateraw requested a review from mishig25 September 26, 2022 21:22

@mishig25 mishig25 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mishig25 mishig25 merged commit 6b1fd8b into main Sep 27, 2022
@mishig25 mishig25 deleted the add-repo-owner-to-build-workflows branch September 27, 2022 07:56
mishig25 pushed a commit that referenced this pull request Sep 27, 2022
mishig25 added a commit that referenced this pull request Sep 27, 2022
@mishig25 mishig25 restored the add-repo-owner-to-build-workflows branch September 27, 2022 07:57
@mishig25

Copy link
Copy Markdown
Contributor

@nateraw thanks a lot for this change!

after some testing, I had to turn remove required: True so that it repo_owner falssback to huggingface default value when non-provided.
Successfully tested a doc-build here & merged here

@nateraw

nateraw commented Sep 27, 2022

Copy link
Copy Markdown
Contributor Author

Thank you, sir!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to build from repos under different org/user

2 participants