Skip to content

Add support for draft pull requests#525

Merged
bitwiseman merged 8 commits into
hub4j:masterfrom
vbehar:draft-pr
Oct 21, 2019
Merged

Add support for draft pull requests#525
bitwiseman merged 8 commits into
hub4j:masterfrom
vbehar:draft-pr

Conversation

@vbehar

@vbehar vbehar commented Jul 11, 2019

Copy link
Copy Markdown
Contributor

@bitwiseman bitwiseman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, now we just need some tests. I've invited you as a collaborator on the test repo, you should be able to use it to write some tests. See CONTRIBUTING for details.

@sullis

sullis commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

any update on this PR? I'd like to start using Draft Pull Requests :)

@bitwiseman

Copy link
Copy Markdown
Member

@sullis
We need tests that show this working in CI. Could you implement them?

@vbehar

vbehar commented Oct 14, 2019

Copy link
Copy Markdown
Contributor Author

Hi,
sorry for not being more active on this one. I'll try to work on the tests this week.
@sullis if you want to do it, please feel free to do so ;-)

@bitwiseman bitwiseman merged commit 72d4b9b into hub4j:master Oct 21, 2019
@vbehar

vbehar commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

thanks @bitwiseman for finishing this and adding the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants