Add support for editing Gists#484
Merged
Merged
Conversation
Fixes issue hub4j#466 NOTE: I could not get the deleteFile() method to work.
bitwiseman
requested changes
May 17, 2019
bitwiseman
left a comment
Member
There was a problem hiding this comment.
You have a ton of PRs up. Thanks! As with others, add some tests and I think we can merge.
Member
|
@martinvanzijl There's actually |
- Created class GHGistUpdater to do the updating. - Added unit tests.
Contributor
Author
|
@bitwiseman I still can't get the |
bitwiseman
approved these changes
Oct 11, 2019
bitwiseman
reviewed
Oct 11, 2019
| } | ||
|
|
||
| // // This method does not work. | ||
| // public GHGistUpdater deleteFile(String fileName) throws IOException { |
Member
There was a problem hiding this comment.
@martinvanzijl
This probably has to do with the way that values are passed via maps.
I suspect passing null results in the key not being set or at least not set to GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #466.
Added the following methods:
NOTE: I could not get the deleteFile() method to work. I have left it commented-out.