Pass options.global as predef arg to JSHINT#216
Merged
thedaviddias merged 4 commits intohtmlhint:developfrom Sep 1, 2018
Merged
Pass options.global as predef arg to JSHINT#216thedaviddias merged 4 commits intohtmlhint:developfrom
thedaviddias merged 4 commits intohtmlhint:developfrom
Conversation
westonruter
added a commit
to xwp/HTMLHint
that referenced
this pull request
Aug 27, 2017
Codecov Report
@@ Coverage Diff @@
## develop #216 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 1 1
======================================
Hits 1 1Continue to review full report at Codecov.
|
thedaviddias
pushed a commit
that referenced
this pull request
Sep 3, 2018
The JSHINT [API](http://jshint.com/docs/api/) specifies that `globals` actually get passed as the `predef`, the 3rd argument to the function and not part of the `options`. This fixes that. Compare with CodeMirror's jshint integration: https://github.com/codemirror/CodeMirror/blob/e49a19f5cacb447558f162014eb26b8c45b30941/addon/lint/javascript-lint.js#L31
thedaviddias
pushed a commit
that referenced
this pull request
Sep 3, 2018
The JSHINT [API](http://jshint.com/docs/api/) specifies that `globals` actually get passed as the `predef`, the 3rd argument to the function and not part of the `options`. This fixes that. Compare with CodeMirror's jshint integration: https://github.com/codemirror/CodeMirror/blob/e49a19f5cacb447558f162014eb26b8c45b30941/addon/lint/javascript-lint.js#L31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSHINT API specifies that
globalsactually get passed as thepredef, the 3rd argument to the function and not part of theoptions. This fixes that.Compare with CodeMirror's jshint integration: https://github.com/codemirror/CodeMirror/blob/e49a19f5cacb447558f162014eb26b8c45b30941/addon/lint/javascript-lint.js#L31