Open
Conversation
salomvary
commented
Mar 31, 2022
| } | ||
| } | ||
|
|
||
| export function reportError(error: FetchResponse | unknown) { |
Author
There was a problem hiding this comment.
We might want a better name for this as reportError is an existing global: https://developer.mozilla.org/en-US/docs/Web/API/reportError
Member
|
Needs a rebase. |
|
Thanks for resurrecting this @salomvary! I was just looking for this functionality today 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr continues abandoned work on #357
I am struggling a bit with adding event firing tests as test cases for failure-scenario are missing for most of the affected functionality and I have not found any documentation on he expected behavior either. For example what do we expect if a request in a Turbo frame fails? Seems like the frame is not updated at all. What do we expect if a Drive link fails? Seems like the page gets updated with the error response.
There is still a test failing and I'm not entirely sure what to expect here:
And lastly, I'm not entirely sure what the semantics of
turbo:errorshould be. Is this for any fetch error response or exception? Should it be limited to fetch errors only? If that's the case, wouldturbo:fetch-errorbe a more appropriate name? I'm personally only interested in fetch error but #357 contains more.Anyway, feedback welcome.