Closed
Conversation
Member
|
This is great. Please do wrap it up and we'll sneak it in before 7.0 final 👍 |
gobijan
reviewed
Sep 2, 2021
| } | ||
|
|
||
| export function reportError(error) { | ||
| console.warn(error) |
There was a problem hiding this comment.
Shouldn't be this console.error to stay true to the method name and the old functionality?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than just emitting any errors to the console, we can emit them as
turbo:errorCustomEvents, allowing the application developer to monitor and raise these to any exception trackers.I think this would make migration to Turbo easier, see #336.
I'd appreciate a quick 👀 on this approach, and then I'd be happy to update the PR with some tests.