Ensure Turbo does not interfere with IFrames#389
Merged
dhh merged 1 commit intohotwired:mainfrom Jul 17, 2022
Merged
Conversation
47786c7 to
391a557
Compare
seanpdoyle
added a commit
to thoughtbot/hotwire-example-template
that referenced
this pull request
Dec 10, 2021
seanpdoyle
added a commit
to thoughtbot/hotwire-example-template
that referenced
this pull request
Dec 10, 2021
Member
|
Still relevant, yeah? |
3a0375e to
d905f09
Compare
Skip intercepting `<a>` element clicks or `<form>` element submissions when they target an `<iframe>`. This occurs when an `<a>` declares a [target][a-target], when a `<form>` declares a [target][form-target], or a `<form>` element's submitting `<button>` element declares a [formtarget][formtarget]. [a-target]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-target [form-target]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#attr-target [formtarget]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-formtarget
d905f09 to
b958895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip intercepting
<a>element clicks or<form>element submissionswhen they target an
<iframe>. This occurs when an<a>declares atarget, when a
<form>declares a target, ora
<form>element's submitting<button>element declares aformtarget.