Replace FormInterceptor with FormSubmitObserver#382
Merged
dhh merged 1 commit intohotwired:mainfrom Jul 18, 2022
Merged
Conversation
5e13bde to
d1f24c7
Compare
d1f24c7 to
495e23c
Compare
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 30, 2021
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). [hotwired#382]: hotwired#382
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Nov 9, 2021
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). [hotwired#382]: hotwired#382
495e23c to
b87e1e1
Compare
Member
|
Worth rebasing too for 7.2.0 👍 |
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 18, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
b87e1e1 to
de281e3
Compare
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 18, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
Unify `<form>` element submission event listening by replacing all `FormInterceptor` call sites and `FormInterceptorDelegate` implementers, replacing them with the `FormSubmitObserver` pattern.
de281e3 to
4712479
Compare
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 19, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 19, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 19, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 19, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 29, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 29, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 30, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 30, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 30, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 31, 2022
Follow-up to hotwired#382 --- In the same style as [hotwired#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired#382]: hotwired#382 [FormLinkInterceptor]: hotwired@f8a94c5
dhh
pushed a commit
that referenced
this pull request
Aug 1, 2022
Follow-up to #382 --- In the same style as [#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [#382]: #382 [FormLinkInterceptor]: f8a94c5
Challenge-Guy
pushed a commit
to Challenge-Guy/turbo-cfm1
that referenced
this pull request
Mar 8, 2025
Follow-up to hotwired/turbo#382 --- In the same style as [hotwired/turbo#382][], replace instances of `LinkInterceptor` with `LinkClickObserver`, making the necessary interface changes in classes that used to extend `LinkInterceptorDelegate`. Conditional logic that was once covered in the `LinkInterceptor` is moved into the predicate methods of the delegates (for example, the `FrameController.willFollowLinkToLocation` and `FrameRedirector.willFollowLinkToLocation`). Since the recently introduced [FormLinkInterceptor][] was named after the `LinkInterceptor`, this commit also renames that class (and its call sites) to match the `LinkClickObserver`-suffix, along with the `LinkInterceptorDelegate` method structure. [hotwired/turbo#382]: hotwired/turbo#382 [FormLinkInterceptor]: hotwired/turbo@f8a94c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify
<form>element submission event listening by replacing allFormInterceptorcall sites andFormInterceptorDelegateimplementers,replacing them with the
FormSubmitObserverpattern.