Omit ignoreActiveValue: true Morph option#1195
Merged
jorgemanrubia merged 1 commit intohotwired:mainfrom Feb 21, 2024
Merged
Conversation
Closes [hotwired#1194][] Rolls back [hotwired#1141][] Don't pass the `ignoreActiveValue: true` option when Morphing. To restore that behavior, applications can set `[data-turbo-permanent]` when form control receives focus (through a `focusin` event listener), then remove it if necessary when the form control loses focus (through a `focusout` event listener). [hotwired#1141]: hotwired#1141 [hotwired#1194]: hotwired#1194
jorgemanrubia
approved these changes
Feb 21, 2024
Member
jorgemanrubia
left a comment
There was a problem hiding this comment.
Thanks a lot @seanpdoyle 🙏
This was referenced Feb 22, 2024
weaverryan
added a commit
to symfony/ux
that referenced
this pull request
Feb 27, 2024
…erryan) This PR was merged into the 2.x branch. Discussion ---------- [Live] Reverting ignoreActiveValue: true in Idiomorph | Q | A | ------------- | --- | Bug fix? | yes/no | New feature? | yes/no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT This setting was recently reverted in Turbo (hotwired/turbo#1195). By setting this to true, it makes it impossible to update the active input's value with a new value from the server (see hotwired/turbo#1194). I had used this to fix a cursor position bug. We now fix it in a different way. Cheers! Commits ------- a15740e [Live] Reverting ignoreActiveValue: true in Idiomorph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1194
Rolls back #1141
Don't pass the
ignoreActiveValue: trueoption when Morphing. To restore that behavior, applications can set[data-turbo-permanent]when form control receives focus (through afocusinevent listener), then remove it if necessary when the form control loses focus (through afocusoutevent listener).