Skip to content

fix(types): fix middleware union type merging in MergeMiddlewareResponse#4602

Merged
yusukebe merged 3 commits into
mainfrom
fix/types-merge-middleware-response
Dec 26, 2025
Merged

fix(types): fix middleware union type merging in MergeMiddlewareResponse#4602
yusukebe merged 3 commits into
mainfrom
fix/types-merge-middleware-response

Conversation

@yusukebe

@yusukebe yusukebe commented Dec 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #4600

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actions Bot commented Dec 26, 2025

Copy link
Copy Markdown

Bundle size check

main (6ca01ec) #4602 (5f675ce) +/-
Bundle Size (B) 18,377B 18,377B 0B
Bundle Size (KB) 17.95K 17.95K 0K

Compiler Diagnostics (tsc)

main (6ca01ec) #4602 (5f675ce) +/-
Files 303 303 0
Lines 141,137 141,139 2
Identifiers 128,905 128,914 9
Symbols 269,466 269,468 2
Types 202,629 202,634 5
Instantiations 609,694 609,702 8
Memory used 341,915K 347,285K 5,370K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.71s 0.72s 0.01s
Bind time 0.3s 0.3s 0s
Check time 2.42s 2.47s 0.05s
Emit time 0s 0s 0s
Total time 3.43s 3.48s 0.05s

Compiler Diagnostics (typescript-go)

main (6ca01ec) #4602 (5f675ce) +/-
Files 303 303 0
Lines 141,139 141,141 2
Identifiers 128,868 128,877 9
Symbols 391,709 387,682 -4,027
Types 372,796 372,805 9
Instantiations 983,880 983,896 16
Memory used 254,651K 253,580K -1,071K
Memory allocs 2,552,752 2,552,648 -104
Config time 0.001s 0.001s 0s
Parse time 0.106s 0.09s -0.016s
Bind time 0.022s 0.032s 0.01s
Check time 0.611s 0.607s -0.004s
Emit time 0s 0s 0s
Total time 0.795s 0.78s -0.015s

Reported by octocov

@github-actions

github-actions Bot commented Dec 26, 2025

Copy link
Copy Markdown

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 35,549.12 48,963.66 31,810.45 25,873.25
hono (current) bun 36,281.65 50,934.02 32,038.90 25,872.02
Change +2.06% +4.02% +0.72% +-0.00%

@codecov

codecov Bot commented Dec 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (6ca01ec) to head (3ec2517).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4602   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         173      173           
  Lines       11256    11256           
  Branches     3266     3266           
=======================================
  Hits        10307    10307           
  Misses        948      948           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe merged commit 489af0b into main Dec 26, 2025
20 checks passed
@yusukebe yusukebe deleted the fix/types-merge-middleware-response branch December 26, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Middleware response type no longer merged with endpoint response type

1 participant

@yusukebe