Skip to content

perf(types): optimize MergeMiddlewareResponse type#4598

Merged
yusukebe merged 1 commit into
mainfrom
perf/types-merge-middleware-response
Dec 25, 2025
Merged

perf(types): optimize MergeMiddlewareResponse type#4598
yusukebe merged 1 commit into
mainfrom
perf/types-merge-middleware-response

Conversation

@yusukebe

@yusukebe yusukebe commented Dec 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions

github-actions Bot commented Dec 25, 2025

Copy link
Copy Markdown

Bundle size check

main (b96b99f) #4598 (5b0af02) +/-
Bundle Size (B) 18,377B 18,377B 0B
Bundle Size (KB) 17.95K 17.95K 0K

Compiler Diagnostics (tsc)

main (b96b99f) #4598 (5b0af02) +/-
Files 303 303 0
Lines 141,136 141,137 1
Identifiers 128,898 128,905 7
Symbols 269,459 269,466 7
Types 205,441 202,629 -2,812
Instantiations 640,325 609,694 -30,631
Memory used 348,541K 341,569K -6,972K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.83s 0.69s -0.14s
Bind time 0.36s 0.29s -0.07s
Check time 2.5s 2.48s -0.02s
Emit time 0s 0s 0s
Total time 3.69s 3.46s -0.23s

Compiler Diagnostics (typescript-go)

main (b96b99f) #4598 (5b0af02) +/-
Files 303 303 0
Lines 141,138 141,139 1
Identifiers 128,861 128,868 7
Symbols 390,491 387,730 -2,761
Types 377,086 372,796 -4,290
Instantiations 1,030,415 983,880 -46,535
Memory used 256,898K 253,744K -3,154K
Memory allocs 2,624,317 2,552,685 -71,632
Config time 0.001s 0.001s 0s
Parse time 0.094s 0.093s -0.001s
Bind time 0.035s 0.021s -0.014s
Check time 0.637s 0.714s 0.077s
Emit time 0s 0s 0s
Total time 0.814s 0.887s 0.073s

Reported by octocov

@github-actions

github-actions Bot commented Dec 25, 2025

Copy link
Copy Markdown

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 39,675.70 54,177.69 35,667.49 29,181.91
hono (current) bun 39,627.34 53,888.52 35,587.15 29,406.36
Change -0.12% -0.53% -0.23% +0.77%

@yusukebe yusukebe marked this pull request as ready for review December 25, 2025 10:26
@codecov

codecov Bot commented Dec 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (b96b99f) to head (2e6e9a6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4598   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         173      173           
  Lines       11256    11256           
  Branches     3267     3267           
=======================================
  Hits        10307    10307           
  Misses        948      948           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe merged commit 27daf50 into main Dec 25, 2025
20 checks passed
@yusukebe yusukebe deleted the perf/types-merge-middleware-response branch December 25, 2025 10:27
@colinlienard colinlienard mentioned this pull request Dec 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cr-tracked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yusukebe