Skip to content

perf(types): reduce Simplify in ToSchema#4597

Merged
yusukebe merged 2 commits into
mainfrom
perf/types-reduce-simplify
Dec 25, 2025
Merged

perf(types): reduce Simplify in ToSchema#4597
yusukebe merged 2 commits into
mainfrom
perf/types-reduce-simplify

Conversation

@yusukebe

@yusukebe yusukebe commented Dec 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actions Bot commented Dec 25, 2025

Copy link
Copy Markdown

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 37,456.25 51,596.30 33,326.67 27,445.79
hono (current) bun 37,044.75 51,110.68 32,660.71 27,362.87
Change -1.10% -0.94% -2.00% -0.30%

@codecov

codecov Bot commented Dec 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (41ee1bb) to head (d36800a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4597   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         173      173           
  Lines       11256    11256           
  Branches     3267     3266    -1     
=======================================
  Hits        10307    10307           
  Misses        948      948           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Dec 25, 2025

Copy link
Copy Markdown

Bundle size check

main (41ee1bb) #4597 (23d6ed8) +/-
Bundle Size (B) 18,377B 18,377B 0B
Bundle Size (KB) 17.95K 17.95K 0K

Compiler Diagnostics (tsc)

main (41ee1bb) #4597 (23d6ed8) +/-
Files 303 303 0
Lines 141,136 141,136 0
Identifiers 128,893 128,898 5
Symbols 269,855 269,459 -396
Types 206,536 205,441 -1,095
Instantiations 666,325 640,325 -26,000
Memory used 352,492K 353,861K 1,369K
I/O read 0.03s 0.02s -0.01s
I/O write 0s 0s 0s
Parse time 0.64s 0.7s 0.06s
Bind time 0.27s 0.29s 0.02s
Check time 2.37s 2.52s 0.15s
Emit time 0s 0s 0s
Total time 3.28s 3.51s 0.23s

Compiler Diagnostics (typescript-go)

main (41ee1bb) #4597 (23d6ed8) +/-
Files 303 303 0
Lines 141,138 141,138 0
Identifiers 128,856 128,861 5
Symbols 392,321 390,522 -1,799
Types 378,666 377,086 -1,580
Instantiations 1,077,904 1,030,415 -47,489
Memory used 257,972K 256,957K -1,015K
Memory allocs 2,719,803 2,624,346 -95,457
Config time 0.001s 0.001s 0s
Parse time 0.089s 0.103s 0.014s
Bind time 0.034s 0.051s 0.017s
Check time 0.571s 0.761s 0.19s
Emit time 0s 0s 0s
Total time 0.735s 0.969s 0.234s

Reported by octocov

@yusukebe

yusukebe commented Dec 25, 2025

Copy link
Copy Markdown
Member Author

Memory used and Total Times are slightly increased, but the Instantiations are reduced significantly. It's okay to merge.

@yusukebe yusukebe merged commit b96b99f into main Dec 25, 2025
36 checks passed
@yusukebe yusukebe deleted the perf/types-reduce-simplify branch December 25, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yusukebe