Skip to content

refactor(client): refactor HonoURL types#4592

Merged
yusukebe merged 1 commit into
mainfrom
refactor/client-hono-url
Dec 25, 2025
Merged

refactor(client): refactor HonoURL types#4592
yusukebe merged 1 commit into
mainfrom
refactor/client-hono-url

Conversation

@yusukebe

@yusukebe yusukebe commented Dec 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This refactoring improves the type performance slightly.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions

github-actions Bot commented Dec 25, 2025

Copy link
Copy Markdown

Bundle size check

main (d8ea652) #4592 (f9fc8d3) +/-
Bundle Size (B) 18,377B 18,377B 0B
Bundle Size (KB) 17.95K 17.95K 0K

Compiler Diagnostics (tsc)

main (d8ea652) #4592 (f9fc8d3) +/-
Files 303 303 0
Lines 141,168 141,136 -32
Identifiers 128,955 128,893 -62
Symbols 269,855 269,855 0
Types 206,545 206,536 -9
Instantiations 666,425 666,325 -100
Memory used 353,063K 350,648K -2,415K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.71s 0.82s 0.11s
Bind time 0.3s 0.29s -0.01s
Check time 2.61s 2.48s -0.13s
Emit time 0s 0s 0s
Total time 3.62s 3.59s -0.03s

Compiler Diagnostics (typescript-go)

main (d8ea652) #4592 (f9fc8d3) +/-
Files 303 303 0
Lines 141,170 141,138 -32
Identifiers 128,918 128,856 -62
Symbols 393,129 392,426 -703
Types 378,675 378,666 -9
Instantiations 1,078,004 1,077,904 -100
Memory used 258,577K 258,105K -472K
Memory allocs 2,721,063 2,719,782 -1,281
Config time 0.001s 0.001s 0s
Parse time 0.089s 0.085s -0.004s
Bind time 0.032s 0.037s 0.005s
Check time 0.62s 0.616s -0.004s
Emit time 0s 0s 0s
Total time 0.795s 0.787s -0.008s

Reported by octocov

@github-actions

github-actions Bot commented Dec 25, 2025

Copy link
Copy Markdown

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 37,666.95 51,018.49 33,577.35 28,405.00
hono (current) bun 37,970.01 52,030.95 33,616.57 28,262.52
Change +0.80% +1.98% +0.12% -0.50%

@yusukebe yusukebe merged commit 41ee1bb into main Dec 25, 2025
18 checks passed
@yusukebe yusukebe deleted the refactor/client-hono-url branch December 25, 2025 02:51
@codecov

codecov Bot commented Dec 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (d8ea652) to head (bb03922).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4592   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         173      173           
  Lines       11256    11256           
  Branches     3266     3266           
=======================================
  Hits        10307    10307           
  Misses        948      948           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yusukebe